TYP: indexes/base.py #39897
TYP: indexes/base.py #39897
Conversation
| @@ -571,11 +580,11 @@ def _simple_new(cls, values, name: Hashable = None): | |||
| return result | |||
|
|
|||
| @cache_readonly | |||
| def _constructor(self): | |||
| def _constructor(self: _IndexT) -> Type[_IndexT]: | |||
There was a problem hiding this comment.
does it matter that a couple of subclasses behave differently?
There was a problem hiding this comment.
Ive typed the subclass methods, I dont think this is a problem.
pandas/core/indexes/base.py
Outdated
| @@ -3663,7 +3672,7 @@ def _invalid_indexer(self, form: str_t, key) -> TypeError: | |||
| # Reindex Methods | |||
|
|
|||
| @final | |||
| def _can_reindex(self, indexer): | |||
| def _can_reindex(self, indexer) -> None: | |||
There was a problem hiding this comment.
misleading name? id expect it to return bool
pandas/core/indexes/base.py
Outdated
| @@ -3403,7 +3412,7 @@ def _check_indexing_method(self, method): | |||
|
|
|||
| raise ValueError("Invalid fill method") | |||
|
|
|||
| def _convert_tolerance(self, tolerance, target): | |||
| def _convert_tolerance(self, tolerance, target) -> np.ndarray: | |||
There was a problem hiding this comment.
i think target at this point is an Index (worth double-checking)
There was a problem hiding this comment.
It can also be an ndarray.
pandas/core/indexes/base.py
Outdated
| @@ -2611,7 +2620,7 @@ def drop_duplicates(self, keep="first"): | |||
|
|
|||
| return super().drop_duplicates(keep=keep) | |||
|
|
|||
| def duplicated(self, keep="first"): | |||
| def duplicated(self, keep="first") -> np.ndarray: | |||
There was a problem hiding this comment.
It can accept a str or a literal False. I've set the type to Union[str, bool].
There was a problem hiding this comment.
For a different PR, bit I don't like the bool type, that can not accept True. I'd like to deprecate the bool type and accept only string parameter options, e.g. "none" instead of False. Any comment on that?
pandas/core/indexes/base.py
Outdated
| @@ -2560,7 +2569,7 @@ def unique(self, level=None): | |||
| return self._shallow_copy(result) | |||
|
|
|||
| @final | |||
| def drop_duplicates(self, keep="first"): | |||
| def drop_duplicates(self: _IndexT, keep="first") -> _IndexT: | |||
There was a problem hiding this comment.
keep is str? (maybe even define literal in pd._typing)
| """ | ||
| Return unique values in the index. | ||
|
|
||
| Unique values are returned in order of appearance, this does NOT sort. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| level : int or str, optional, default None | ||
| level : int or hashable, optional |
There was a problem hiding this comment.
"hashable" seems weird here. may parenthetically "level name"?
There was a problem hiding this comment.
I've tried adding a text below the types.
pandas/core/indexes/base.py
Outdated
| @@ -1243,7 +1252,7 @@ def to_flat_index(self): | |||
| """ | |||
| return self | |||
|
|
|||
| def to_series(self, index=None, name=None): | |||
| def to_series(self, index=None, name=None) -> Series: | |||
|
Updated. |
|
thanks @topper-123 |
Add types to
pandas/core/indexes/base.py.